fix(einfo): the monster name is the last field, so it has to opt into escaping - #507
Conversation
… escaping A trailing string field keeps its spaces unless it asks not to, and a monster name is the last field of e_info. 929 of the 1109 monster info lines in a real capture carry a space, across 630 distinct names, so without the flag the field splits and everything after the first word is read as extra fields. Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: CHILL Plan: Pro Plus Run ID: 📒 Files selected for processing (2)
Included review availability: Your plan provides up to 1 included review per hour; 0 remain after this review. WalkthroughThe ChangesNPC monster name serialization
Estimated code review effort: 1 (Trivial) | ~5 minutes Merge Risk: ⚪ Minimal · up to The change correctly escapes spaces in trailing monster names so packet fields are parsed reliably; focused tests and the full build/test suite pass, and no actionable merge-blocking risk remains. Suggested reviewers: 🚥 Pre-merge checks | ✅ 4 | ❌ 1❌ Failed checks (1 warning)
✅ Passed checks (4 passed)
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
2 participants
A trailing string field keeps its spaces unless it opts in, and
Nameis thelast field of
e_info. Without the flag the line endsand everything after the first word is read as extra fields.
It is not a rare shape: 929 of the 1109 monster info lines in a capture carry a
name with a space in it, across 630 distinct names.
What was tested
Added to
AFieldThatOptsInIsEscapedEvenThoughItIsLast, next to the two fieldsthat already opt in. Written red first: without the flag it fails with
actual: "... -1 Mother Cuby", with it the tail readsMother^Cuby.dotnet build: 0 warnings.dotnet test: 127/127.What was NOT tested
Not played. This is the packet model only; the server side that fills the field
is a separate change.
Summary by CodeRabbit
Bug Fixes
Tests